Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11565 Improve error logging main #124

Merged
merged 4 commits into from
Jan 13, 2025
Merged

Conversation

d-s-codappix
Copy link
Contributor

REBASE, not squash

@d-s-codappix d-s-codappix self-assigned this Jan 13, 2025
The upstream library got a change within
php_unit_test_case_static_method_calls rule.
This is now applied.
As PHPStan changed the error message for an existing error.
As test data has fixed dates and times.
That way we ensure tests will pass at any given date and time, as the
used date and time while executing matches the expected one for the test
data.
This should ease debugging and allow users to fix broken data.

Relates: #11565
@d-s-codappix d-s-codappix force-pushed the 11565-improve-error-logging-main branch from f34e715 to bd93524 Compare January 13, 2025 08:31
@d-s-codappix d-s-codappix requested a review from a team January 13, 2025 08:42
@d-s-codappix d-s-codappix merged commit 39b58eb into main Jan 13, 2025
13 checks passed
@d-s-codappix d-s-codappix deleted the 11565-improve-error-logging-main branch January 13, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants