Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix warnings #282

Merged
merged 3 commits into from
Dec 13, 2024
Merged

chore(ci): fix warnings #282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
43afe97
chore(ci): fix warnings
Fral738 Dec 12, 2024
c43fc5a
chore(ci): fix notification
Fral738 Dec 12, 2024
97b9266
chore(ci): fix lint
Fral738 Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/_notification.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,13 @@ jobs:
echo 'failed<<EOF' >> $GITHUB_OUTPUT
echo "$(curl ${{ github.api_url }}/repos/${{ github.repository }}/actions/runs/${{ github.run_id }}/jobs | jq -r '.jobs[]| select (.conclusion == "failure") | .html_url')" >> $GITHUB_OUTPUT
echo 'EOF' >> $GITHUB_OUTPUT
- if: (env.WORKFLOW_CONCLUSION == 'failure' && startsWith(github.ref, 'refs/pull/'))
- if: env.WORKFLOW_CONCLUSION == 'failure' && (startsWith(github.ref, 'refs/pull/') || github.event_name == 'workflow_dispatch')
name: get user
id: get_user
run: |
echo username=$(curl ${{ github.api_url }}/users/${{ github.triggering_actor }} | jq -r '.name' | tr '[:upper:]' '[:lower:]' | tr " " . ) >> $GITHUB_OUTPUT

- if: "(env.WORKFLOW_CONCLUSION == 'failure' && ! startsWith(github.ref, 'refs/pull/'))"
- if: "(env.WORKFLOW_CONCLUSION == 'failure' && ! startsWith(github.ref, 'refs/pull/') && github.event_name != 'workflow_dispatch' )"
name: Failure notify
uses: mattermost/action-mattermost-notify@master
with:
Expand All @@ -60,7 +60,7 @@ jobs:
Workflow успешно завершился в ${{ github.repository }} :bender:
[${{ github.workflow }}](${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}) ${{ github.ref_name }} :success:

- if: (env.WORKFLOW_CONCLUSION == 'failure' && startsWith(github.ref, 'refs/pull/'))
- if: env.WORKFLOW_CONCLUSION == 'failure' && (startsWith(github.ref, 'refs/pull/') || github.event_name == 'workflow_dispatch')
name: Failure notify for PRs
uses: mattermost/action-mattermost-notify@master
with:
Expand Down
9 changes: 4 additions & 5 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ jobs:
run: ginkgo --vet=off --race --keep-going --cover --coverpkg=./... --output-dir=$TRDL_TEST_COVERAGE_DIR ./...

- name: Upload coverage artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: tests_coverage
path: tests_coverage
Expand Down Expand Up @@ -117,9 +117,9 @@ jobs:
run: ginkgo -p --keep-going --cover --coverpkg=../client/...,../server/... --output-dir=$TRDL_TEST_COVERAGE_DIR ./...

- name: Upload coverage artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: tests_coverage
name: e2e_coverage
path: tests_coverage

upload_coverage:
Expand All @@ -138,9 +138,8 @@ jobs:
go-version-file: e2e/go.mod

- name: Download coverage artifact
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: tests_coverage
path: tests_coverage

- name: Prepare environment
Expand Down
2 changes: 1 addition & 1 deletion Taskfile.dist.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ tasks:
- npm install -g prettier

lint:
desc: 'Run all linters in parallel.'
desc: "Run all linters in parallel."
deps:
- lint:prettier

Expand Down
Loading