Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update socket_handler.rb #646

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions lib/whois/server/socket_handler.rb
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,19 @@ def call(query, *args)
# @api private
#
def execute(query, *args)
client = TCPSocket.new(*args)
client.write("#{query}\r\n") # I could use put(foo) and forget the \n
client.read # but write/read is more symmetric than puts/read
begin
client = TCPSocket.new(*args)
Thread.new do
begin
client.write("#{query}\r\n") # I could use put(foo) and forget the \n
rescue => e
print e.message
end
end
client.read # but write/read is more symmetric than puts/read
rescue => e
print e.message
end
ensure # and I really want to use read instead of gets.
client.close if client # If != client something went wrong.
end
Expand Down