Integrate type inf #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR restores the Github actions workflow from the verify-main-2023-01-10 branch. In addition, we fixup some Cranelift warnings since the Rust setup step from the Wasmtime CI runs with warnings treated as errors.
This PR fixes a bug in the Solver in dynamic width mode and onlywidths true, where the y operand of a BVShr expression will not be visited. This can cause type inference to fail. This problem came up when trying to use a Sail-generated specification that contained a concat expression in the right-hand-side operand.
This doesn't work the same on x64 as it does on arm, and ends up deleting important parts of the trace.
…ing from workaround
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.