Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

347 missing values #348

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

quantenschaum
Copy link
Contributor

@quantenschaum quantenschaum commented Jul 1, 2024

Here is a starting point to fix #347

  • check for missing values in NMEA parser and omit then (do not set to zero)
  • added parsing of DBK and DBS sentences
  • hide course vector if COG is undefined
  • hide course vectors in heading mode if zero SOG is detected
  • adjusted widgets to display --- as default if values are undefined
  • frontend: merge dicts in state model to collect nested additionalKeys

@quantenschaum
Copy link
Contributor Author

I would like to ask you have a look into this and merge it. I contains some IMHO important fixes.

  • The tree of values in the frontend that is kept in sync with the values on the server is not updated correctly for subtrees (like in the sail instrument). This is fixed by cfb8a86
  • missing/non-present values should not be set to zero but to nothing. Zero and not value/undefined value are different things.
  • missing/non-present values should not be displayed as zero, it should display --- to indicate that there is no value for this property.
  • The same holds true for the heading/course vectors on the chart, if there is no data, do not display them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NMEA decoding, missing values treated as zero
1 participant