[전현수] 기적의 매매법, 수 이어 쓰기 1, 등수 구하기, DNA #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeeminimini
reviewed
Jan 1, 2023
Comment on lines
+16
to
+32
| data class Wallet( | ||
| var remainedCash: Int = 0, | ||
| var ownedStockCnt: Int = 0, | ||
| ) { | ||
|
|
||
| fun sellStock(price: Int) { | ||
| remainedCash += ownedStockCnt * price | ||
| ownedStockCnt = 0 | ||
| } | ||
|
|
||
| fun buyStock(price: Int) { | ||
| ownedStockCnt += remainedCash / price | ||
| remainedCash %= price | ||
| } | ||
|
|
||
| fun getStockWorth(price: Int) = ownedStockCnt * price + remainedCash | ||
| } |
| for (j in 0 until dnaCnt) { | ||
| val curAlphabet = dnaList[j][i] | ||
| alphabetMap[curAlphabet] = | ||
| alphabetMap.getOrDefault(curAlphabet, 0) + 1 |
Comment on lines
+37
to
+39
| hammingDistance += | ||
| alphabetMap.filter { it.key != mostFrequentAlphabet } | ||
| .map { it.value }.sum() |
There was a problem hiding this comment.
sum으로 다른걸 더하는 것보다 max인 value를 dnaCnt에서 빼도 될 것 같습니다!
There was a problem hiding this comment.
@jeeminimini
좋은 방법 감사합니다!!
| } else { | ||
| repeat(digit) { zeroCnt -> | ||
| answer += if (zeroCnt == 0) 9 | ||
| else ("9" + "0".repeat(zeroCnt)).toInt() * (zeroCnt + 1) |
jeeminimini
approved these changes
Jan 1, 2023
bngsh
approved these changes
Jan 1, 2023
Comment on lines
+26
to
+29
| fun buyStock(price: Int) { | ||
| ownedStockCnt += remainedCash / price | ||
| remainedCash %= price | ||
| } |
There was a problem hiding this comment.
저는 파는 부분은 성민이만 필요하길래 따로 함수로 안 뺐는데 둘다 빼주는게 추상화 레벨(?)이 맞아서 더 깔끔했겠다는 생각을 했습니다
| .sortedByDescending { it } | ||
|
|
||
| newList | ||
| .lastIndexOf(newScore).apply { |
There was a problem hiding this comment.
고차함수를 쓰니 이렇게 깔꼼하게 풀리는 문제였군요...
|
|
||
| val mostFrequentAlphabet = alphabetMap | ||
| .toSortedMap() | ||
| .maxBy { it.value }.key |
jhg3410
approved these changes
Jan 1, 2023
Comment on lines
+21
to
+29
| fun sellStock(price: Int) { | ||
| remainedCash += ownedStockCnt * price | ||
| ownedStockCnt = 0 | ||
| } | ||
|
|
||
| fun buyStock(price: Int) { | ||
| ownedStockCnt += remainedCash / price | ||
| remainedCash %= price | ||
| } |
Comment on lines
+30
to
+31
| newList.indexOf(newScore).apply { | ||
| println(this + 1) |
There was a problem hiding this comment.
lastIndexOf 랑 indexOf 나눈 게 좋습니다!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 from issue #61 📌
📋문제 목록📋
📍추가로 해결한 문제📍
📝메모
DNA 문제를 이해 못해서 정말 시간을 많이 버렸습니다.... 제 문해력이 딸리는 건지...
혹시 저 같으신 분이 있으실까봐 문제의 이해를 위해 참고한 블로그 링크 남겨봅니다!!! (구현 자체는 쉬웠어용)
DNA 문제 이해가 안되어서 참고한 곳
투 포인터 연습할라고 문제 조금 더 풀었슴다..