[소병희] Java vs C++, 1,2,3 더하기 4, 도어맨, 배열 복원하기, 후위 표기식2 #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeeminimini
reviewed
Nov 13, 2022
Comment on lines
+17
to
+19
| wait.indexOfFirst { | ||
| count += it | ||
| abs(count) > d + 1 |
There was a problem hiding this comment.
indexOfFirst 신기하네요!! count가 계속 실행된다는 것을 병희님 덕분에 알게 되었습니다
Comment on lines
+20
to
+23
| }.let { ans -> when (ans) { | ||
| -1 -> if (abs(count) == d + 1) println(wait.size - 1) else println(wait.size) | ||
| else -> println(ans - 1) | ||
| } } |
There was a problem hiding this comment.
로직이 넘 깔끔해서 감탄했습니다!! 차이에서 하나를 더 더한 걸 생각한게 놀라웠어요
Comment on lines
+31
to
+39
| val op: (Double, Double) -> Double = | ||
| when (opC) { | ||
| MUL -> { b, a -> a * b } | ||
| DIV -> { b, a -> a / b } | ||
| ADD -> { b, a -> a + b } | ||
| SUB -> { b, a -> a - b } | ||
| else -> { _, _ -> 0.0 } | ||
| } | ||
| st.addLast(op(n1, n2)) |
jhg3410
approved these changes
Nov 13, 2022
Comment on lines
+29
to
+37
| if (prev == UNDERSCORE) { | ||
| if (cur.isLowerCase()) { | ||
| sb.append(cur.uppercase()) | ||
| } | ||
| else error() | ||
| } | ||
| else if (cur.isUpperCase()) { | ||
| sb.append("_${cur.lowercase()}") | ||
| } |
There was a problem hiding this comment.
굳이 C++ 랑 JAVA 나누지 않고 이렇게 하는 게 더 좋네요!👍
| matrixA[r][c] = matrixB[r][c] - matrixA[r - x][c - y] | ||
| } | ||
|
|
||
| println(matrixA.joinToString("\n") { it.joinToString(" ")}) |
Comment on lines
+31
to
+38
| val op: (Double, Double) -> Double = | ||
| when (opC) { | ||
| MUL -> { b, a -> a * b } | ||
| DIV -> { b, a -> a / b } | ||
| ADD -> { b, a -> a + b } | ||
| SUB -> { b, a -> a - b } | ||
| else -> { _, _ -> 0.0 } | ||
| } |
soopeach
approved these changes
Nov 13, 2022
| println(st.last().let{ String.format("%.2f", it) }) | ||
| } | ||
|
|
||
| fun calc(n1: Double, n2: Double, opC: Char) { |
There was a problem hiding this comment.
ArrayDeque가 이미 calc에서 접근이 가능하기 때문에 굳이 n1, n2인지가 필요없을 것 같아요!!
| DIV -> { b, a -> a / b } | ||
| ADD -> { b, a -> a + b } | ||
| SUB -> { b, a -> a - b } | ||
| else -> { _, _ -> 0.0 } |
There was a problem hiding this comment.
_, _ 로 사용하지 않는 변수들을 명시하신 것이 좋은 것 같습니다!
| matrixA[r][c] = matrixB[r][c] - matrixA[r - x][c - y] | ||
| } | ||
|
|
||
| println(matrixA.joinToString("\n") { it.joinToString(" ")}) |
There was a problem hiding this comment.
joinToString을 두 번 사용해서 출력 형식을 맞춘 부분이 이쁜 것 같습니다!
|
|
||
| class 소병희_java_vs_cpp { | ||
| companion object { | ||
| const val UNDERSCORE = '_' |
jeeminimini
approved these changes
Nov 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 from issue #41 📌
📋문제 목록📋