This repository has been archived by the owner on May 8, 2024. It is now read-only.
feat: Date Handling -- add unittest based on manually curated data and more... #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobBorges
changed the title
|
unit test will still fail -- we're waiting for double/triple check on a handful of mandate dates |
ninpnin
approved these changes
Feb 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A unit test based on work by Lotta, Fredrik and Mattias manually checking MP start/end dates.
Unfortunately fails because of the data, but I will post that in a separate issue.
Two files from pyriksdagen snuck their way in here due to parallel work on the same branch -- I didn't intend to push them right now, but the edits won't hurt anything.
EDIT, since I accidentally committed these two files from pyriksdagen, I have other things to add, and we have the student pool working on the dates that fail the unit test here, I'm going to add some more features relating to the date handling...