Skip to content
This repository has been archived by the owner on May 8, 2024. It is now read-only.

Adding dynamic README #413

Merged
merged 16 commits into from
Dec 13, 2023
Merged

Adding dynamic README #413

merged 16 commits into from
Dec 13, 2023

Conversation

BobBorges
Copy link
Collaborator

Adding dynamically updated summary stats and plots.

  • protocols: number, pages, speeches, words
  • motions: not yet implemented (no motions in the main repo yet)
  • MEPs: number per year
  • quality control: speaker-speech mapping, ratio MEP to baseline

Scripts run as part of the release workflow.

A few points relating to quality control from the original issue are not included (not yet implemented), but can be added later.

closes #291

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link
Collaborator

@MansMeg MansMeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some minor commeths thoughts. But otherwise Im happy to merge.

@BobBorges
Copy link
Collaborator Author

Aside from the funding acknowledgement comment above, I think I resolved all the requested changes. @MansMeg

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@MansMeg
Copy link
Collaborator

MansMeg commented Nov 21, 2023

Three minor additional questions/suggestions.

@BobBorges
Copy link
Collaborator Author

another (sorry) issue, is that the VR logo looks like crap with github in darkmode -- I doubt any of them look at github, much less in darkmode, but they don't offer a non-transparent logo, so it either look bad in one mode or the other.
image

@fredrik1984
Copy link
Collaborator

another (sorry) issue, is that the VR logo looks like crap with github in darkmode

I just took one that I found on google. try to find a better if you can and if there are none skip it.

@BobBorges
Copy link
Collaborator Author

another (sorry) issue, is that the VR logo looks like crap with github in darkmode

I just took one that I found on google. try to find a better if you can and if there are none skip it.

I mean, I downloaded their official logo pack and they're all transparent. If I get creative, I'll take it to photoshop or whatever. I guess most people use light mode anyway, for whatever reason.

@MansMeg
Copy link
Collaborator

MansMeg commented Nov 21, 2023

Then I think we are done! Im happy now!

@ninpnin ninpnin merged commit 1ae5f5b into dev Dec 13, 2023
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants