Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow silencing predict tile stdout #874

Closed
wants to merge 4 commits into from

Conversation

ethanwhite
Copy link
Member

See Lightning-AI/pytorch-lightning#13358

I'm not sure what's going on with the test in #854 but I took the original commit, rebased it against main, cleanup up a style issue, and tests seem to be passing on my fork.

@bw4sz
Copy link
Collaborator

bw4sz commented Jan 7, 2025

Thanks for jumping in. The test above yields the same error as mine, but I can't find any reason it doesn't show locally. Same pytorch-lightning version.

@ethanwhite
Copy link
Member Author

What's weird is that the individual test passed locally in my fork. Let me try a couple more things...

@ethanwhite
Copy link
Member Author

ethanwhite commented Jan 7, 2025

So if we just run the test that was failing it passes.

So the most likely scenario is that there is some sort of state persisting in the tests that is causing the issue and for some reason it's happening on GitHub but not locally on Ubuntu 22.04 (for me)

@henrykironde
Copy link
Contributor

Yah , I got the same here.

@ethanwhite
Copy link
Member Author

Still failing here with Ubuntu 22.04, so that won't help us replicate locally

@ethanwhite
Copy link
Member Author

This issue and PR might be useful?

@bw4sz
Copy link
Collaborator

bw4sz commented Jan 9, 2025

Can close in favor of #878

@bw4sz
Copy link
Collaborator

bw4sz commented Jan 13, 2025

I think this can be closed.

@bw4sz bw4sz closed this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants