updated main.deepforest.predict_file for DF usage #852
Conversation
|
Its clearing all the tests in local environment. I don't know why its not showing in github |
That is weird. Can you try either opening a new PR from the same branch or pushing a tiny change to a comment to see if it will trigger the build (or ask us to trigger it). |
|
That did it. I think there was just hiccup with the prompt asking us to allow the tests to run (since you're a new contributor). The build failure is something that just cropped up with an image change. Hopefully #855 will fix that and then we can rerun |
|
Okay. I was very confused as to what went wrong. This certainly helps. |
|
@naxatra2 - If you rebase this on |
|
Is this good ? |
|
Thanks @naxatra2 - tests are passing now. We'll try to review the PR next week. |
accidentally committed to the wrong branch so removed it
|
@naxatra2 - looks like a style issue crept in with your updated commits. See https://deepforest.readthedocs.io/en/v1.4.1/development/contributing.html#using-yapf to fix it and then we'll get this reviewed for you now that the holidays are over |
| @@ -649,8 +649,7 @@ def test_predict_tile_with_crop_model(m, config): | |||
| "xmin", "ymin", "xmax", "ymax", "label", "score", "cropmodel_label", "geometry", | |||
| "cropmodel_score", "image_path" | |||
| } | |||
|
|
|||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Is it possible to come up with some test for the added feature functionality?
There was a problem hiding this comment.
okay. I will write a new test case and commit it
henrykironde
added
the
Awaiting author contribution
Fixes #797
In the
main.deepforest.predict_fileshould now also be able to take in a dataframe, not just a csv file.There was another PR open (PR #838) for similar issue but it wasn't working so I improved it.