Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update overview.rst #883

Merged
merged 4 commits into from
Jan 14, 2025
Merged

Update overview.rst #883

merged 4 commits into from
Jan 14, 2025

Conversation

bw4sz
Copy link
Collaborator

@bw4sz bw4sz commented Jan 13, 2025

The youtube link for the ESA seminar is available.

The youtube for the ESA seminar is available.
@bw4sz bw4sz requested a review from henrykironde January 13, 2025 17:43
@ethanwhite
Copy link
Member

The docs error is coming from https://about.readthedocs.com/blog/2024/12/deprecate-config-files-without-sphinx-or-mkdocs-config/. I've asked @henrykironde to get this fixed when he has a minute

Copy link
Contributor

@henrykironde henrykironde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add configuration: docs/conf.py to the PR. I have sent a PR to the branch.

docs/getting_started/overview.rst Outdated Show resolved Hide resolved
@ethanwhite
Copy link
Member

I'm going to go ahead and merge this, but the history is a little messy since we have two distinct changes (a fix to the docs build and a change to the docs) but also two cleanup commits. So neither squashing or just merging is ideal.

A good skill in cases like this in the future if fixup commits, which let you clean up a commit even if it isn't the most recent one. Nice description of fixup commits for reference.

@ethanwhite ethanwhite merged commit 7d0a0bb into main Jan 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants