Fix puppet not set issue in RoomInvitation #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Whenever operations related to room invitations were performed, an error
<puppet not set>occurred. After tracing the root of the problem, it was identified that theloadmethod in theRoomInvitationclass was not correctly associating the puppet with the new instance ofRoomInvitation.Further details can be found in the related issue: Issue #354.
Solution
Adjusted the
loadmethod in theRoomInvitationclass. The method was previously creating a new instance ofRoomInvitationwithout correctly setting up the puppet. By using theclsmethod for instantiation, we ensure that the puppet is properly associated with theRoomInvitationobject.Changes
loadmethod in theRoomInvitationclass to utilizeclsfor instantiation, ensuring the puppet is set correctly.Please review these changes and let me know if further adjustments are required.
Thank you!