another try to remove job observer leaks

webtor-io · Oct 9, 2024 · dce5d1a · dce5d1a
1 parent 9826729
commit dce5d1a
Showing 1 changed file with 7 additions and 9 deletions.
diff --git a/services/job/job.go b/services/job/job.go
@@ -22,14 +22,12 @@ func (s *Observer) Push(v LogItem) {
 	if s.closed {
 		return
 	}
-	go func() {
-		select {
-		case <-time.After(5 * time.Minute):
-			return
-		case s.C <- v:
-			return
-		}
-	}()
+	select {
+	case <-time.After(5 * time.Minute):
+		return
+	case s.C <- v:
+		return
+	}
 }
 
 func (s *Observer) Close() {
@@ -171,7 +169,7 @@ func (s *Job) ObserveLog() *Observer {
 
 func (s *Job) pushToObservers(l LogItem) {
 	for _, o := range s.observers {
-		o.Push(l)
+		go o.Push(l)
 	}
 }