Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

override: add IntersectionObserver(callback, options) constructor override #137

Merged
merged 1 commit into from
Feb 22, 2024
Merged

override: add IntersectionObserver(callback, options) constructor override #137

merged 1 commit into from
Feb 22, 2024

Conversation

ikreymer
Copy link
Member

IntersectionObserver(callback, options) has an options.root field which may be a document, and must be de-proxied.

This PR adds an initIntersectionObsOverride override which overrides the IntersectionObserver class with a derived class that wraps the original and deproxies options.root.

Fixes #136

@ikreymer
override: add IntersectionObserver(callback, options) constructor ove…
4d1e290 
…rride, which will deproxy options.root if it is set

fixes #136
@ikreymer ikreymer merged commit a3b0f8b into main Feb 22, 2024
4 checks passed
@ikreymer ikreymer deleted the intersectionobserver-override branch February 22, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IntersectionObserver constructor throws TypeError due to document being a proxy
1 participant
@ikreymer