Prepend HTTPS to Crawl Start URL #2177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (except for URL list) part of fix for #2167
|
Might be good enough for 1.12.2, as this addresses most common issue, can handle list of urls in a follow-up. |
tw4l
approved these changes
Nov 23, 2024
| @@ -996,6 +1008,18 @@ https://archiveweb.page/guide`} | |||
| const text = msg("Please enter a valid URL."); | |||
| inputEl.helpText = text; | |||
| inputEl.setCustomValidity(text); | |||
| inputEl.setCustomValidity(text); | |||
There was a problem hiding this comment.
This appears to be a duplicate of the line above - maybe a mistake?
ikreymer
commented
Nov 23, 2024
add validation onblur for url list
|
Decided to go ahead and just add URL list prepending as well for completion! |
…just using single limit todo: make customizable in the future
Merged
ikreymer
added a commit
that referenced
this pull request
Nov 26, 2024
Merge 1.12.2 release changes into main, includes: - Collection replay full refresh on metadata / archived items (#2176) - Fix for self-registration default org (#2178) - Prepend missing https in start URL (#2177) - Updated billing to support free trial messaging (#2179) --------- Co-authored-by: sua yoo <[email protected]> Co-authored-by: Henry Wilkinson <[email protected]> Co-authored-by: sua yoo <[email protected]> Co-authored-by: SuaYoo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of fix for #2167:
https://if URL is considered valid but missing schemehttps://to each URL in URL list, also run validation onblur for URL list