Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Derive org ID from shared state #1985

Merged

Conversation

SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented Jul 31, 2024

WIP for #1741

Changes

  • Moves userOrg getter from <btrix-org> to app state
  • Batches mutations in app state actions

@SuaYoo SuaYoo changed the base branch from main to frontend-shared-state-refactors July 31, 2024 22:11
@SuaYoo SuaYoo force-pushed the frontend-shared-org-id-state branch from a28dcfb to 68dea65 Compare August 1, 2024 04:07
@SuaYoo SuaYoo requested a review from emma-sg August 1, 2024 04:14
@SuaYoo SuaYoo marked this pull request as ready for review August 1, 2024 04:52
@SuaYoo SuaYoo merged commit fc43f6e into frontend-shared-state-refactors Aug 5, 2024
2 checks passed
@SuaYoo SuaYoo deleted the frontend-shared-org-id-state branch August 5, 2024 18:07
SuaYoo added a commit that referenced this pull request Aug 6, 2024
- Moves `userOrg` getter from `<btrix-org>` to app state
- Batches mutations in app state actions
SuaYoo added a commit that referenced this pull request Aug 13, 2024
Refactors custom components to enable shared state accessors
(like `authState`) and helpers (like `api.fetch`.) Schemas are now
defined with [zod](https://zod.dev/?id=basic-usage) which enables
runtime schema validation.

See subtasks for full description of change:

- #1979
- #1981
- #1985
- #1986

---------

Co-authored-by: Emma Segal-Grossman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant