Fix the iframe background color #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this works. Originally when I did this 8 months ago I set the CSS a certain way that works in Chrome but not Firefox. I filed a bug for Firefox https://bugzilla.mozilla.org/show_bug.cgi?id=1885048 They pointed out the bug is in Chrome and Firefox is correct. I put the CSS to match what Firefox said was correct and found the corresponding bug in Chrome which was basically being ignored. (I can't seem to find the bug now) Anyway, my understanding is, since the web started, iframes content gets the background color of the iframe element. Unless of course they set their own background color and that, with white being the default backgrounc color, most pages expect a white background and so iframe elements need have a white background otherwise content breaks. Often colors are now set via `color-scheme` but color-scheme is ignored in the iframe content if its the same as the iframe element's color-scheme because otherwise the previous rule about background color would be un-enforced. The solution appears to be, set the iframe element's color-scheme to "initial". Now the iframe's content color-scheme setting is not ignored.
This was referenced Nov 15, 2024
|
The PR looks good in general but it does not fix my original issue. You can try it at http://localhost:8080/?sample=computeBoids. The perf UI text (in white) is not visible as the iframe background is white. |
|
Sorry I got confused that this was the computeboids demo and not the new timestamp demo. That one uses a black background for the stats. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally when I did this 8 months ago I set the CSS a certain way that works in Chrome but not Firefox. I filed a bug for Firefox
https://bugzilla.mozilla.org/show_bug.cgi?id=1885048
They pointed out the bug is in Chrome and Firefox is correct. I put the CSS to match what Firefox said was correct and found the corresponding bug in Chrome which was basically being ignored. (I can't seem to find the bug now)
Anyway, my understanding is, since the web started, iframes content gets the background color of the iframe element. Unless of course they set their own background color and that, with white being the default backgrounc color, most pages expect a white background and so iframe elements need have a white background otherwise content breaks.
Often colors are now set via
color-schemebut color-scheme is ignored in the iframe content if its the same as the iframe element's color-scheme because otherwise the previous rule about background color would be un-enforced.The solution appears to be, set the iframe element's color-scheme to "initial". Now the iframe's content color-scheme setting is not ignored.
Safari - Light
Safari - Dark
Firefox - Light
Firefox - Dark
Chrome - Light
Chrome - Dark