Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Extensions #482

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Docs: Extensions #482

wants to merge 1 commit into from
+72 −0

Conversation

kainino0x
Copy link
Collaborator

Issue: #214

@kainino0x kainino0x requested a review from lokokung December 21, 2024 07:13
kainino0x
kainino0x commented Dec 21, 2024
View reviewed changes
doc/articles/Extensions.md
| | Prefix | Enum Block | Description
|--------------------|--------------|---------------|------------
| Core | (none) | `0x0000_????` | Extensions that are required to implement (e.g. added after 1.0).
| Multi-Vendor | (none) | `0x0001_????` | Extensions that are optional to implement (e.g. platform-specific extensions). *TBD if enum values in this block may become required, or if they would be aliased into block `0x0000_????` first.*
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a question buried here which I noticed in #417 and then completely forgot about.

Should the new enums really use block 0x0001? Seems like if we ever put this stuff in "core" they could use the same enums, would we then duplicate them into block 0x0000 or just use the block 0x0001 values? Or should we just put them in block 0x0000 to start?

Ugh. Can't keep track of all this minutiae.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cwfitzgerald any thoughts? (no rush, I'm ~out until Jan)

@kainino0x kainino0x added the !discuss Needs discussion (at meeting or online) label Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lokokung lokokung Awaiting requested review from lokokung

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
!discuss Needs discussion (at meeting or online)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kainino0x