Proposal: Rename WGPUProgrammableStageDescriptor -> WGPUComputeStage #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In JS, `WGPUProgrammableStage` (no `Descriptor`, it was renamed) is the base dictionary for vertex/fragment/compute. But in C we don't use it for that, we only use it for compute because compute doesn't add any other members. So we should name it accordingly. Since the JS type is `WGPUProgrammableStage`, I've called it `WGPUComputeStage`. Both `WGPUComputePipelineDescriptor` and `WGPUComputeStage` are still both extensible, which makes reasonable sense and matches `WGPURenderPipelineDescriptor`/`WGPUVertexState`/`WGPUFragmentState`. Fixes 409
Kangz
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In JS,
WGPUProgrammableStage(noDescriptor, it was renamed) is the base dictionary for vertex/fragment/compute. But in C we don't use it for that, we only use it for compute because compute doesn't add any other members. So we should name it accordingly. Since the JS type isWGPUProgrammableStage, I've called itWGPUComputeStage.Both
WGPUComputePipelineDescriptorandWGPUComputeStageare still both extensible, which makes reasonable sense and matchesWGPURenderPipelineDescriptor/WGPUVertexState/WGPUFragmentState.(Note naming:
StatevsStage. This could beWGPUComputeStatebut that didn't make as much sense to me. Not sure if it's better for it to match.)Fixes #409
(dawn bug https://crbug.com/379059434)