Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: style improvements and enhancements to the Prerequisites page. #388

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

gosteenBASIS
Copy link
Contributor

Since the Prerequisites page is one of the first pages users will see, I've improved the style, grammar, layout, and user-friendliness of the page.

docs/introduction/prerequisites.md Show resolved Hide resolved
docs/introduction/prerequisites.md Outdated Show resolved Hide resolved
docs/introduction/prerequisites.md Show resolved Hide resolved
Copy link
Contributor

@bbrennanbasis bbrennanbasis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gosteenBASIS I've added my feedback for this PR.

docs/introduction/prerequisites.md Outdated Show resolved Hide resolved
docs/introduction/prerequisites.md Show resolved Hide resolved
docs/introduction/prerequisites.md Outdated Show resolved Hide resolved
docs/introduction/prerequisites.md Outdated Show resolved Hide resolved
docs/introduction/prerequisites.md Outdated Show resolved Hide resolved
docs/introduction/prerequisites.md Show resolved Hide resolved
Copy link
Member

@hyyan hyyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The term "webforJ" is excessively repeated within a single paragraph, and it is written in different casing inconsistently.

Changed open-source to open source
Changed "can be found at" to "can be found on"
Changed "a couple prerequisites" to "a couple of prerequisites"
@gosteenBASIS gosteenBASIS force-pushed the improve-prerequisites branch from bd9f9a7 to 5cf8dc0 Compare January 13, 2025 21:44
@gosteenBASIS
Copy link
Contributor Author

I've reworded some sentences to avoid using webforJ at the beginning, and removed the first header as Hyyan requested.

@hyyan hyyan self-requested a review January 14, 2025 13:04
@hyyan
Copy link
Member

hyyan commented Jan 14, 2025

/rebase

@MatthewHawkins MatthewHawkins merged commit dc7e7e7 into website Jan 14, 2025
1 check failed
@MatthewHawkins MatthewHawkins deleted the improve-prerequisites branch January 14, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants