Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Toolbar article #299

Open
wants to merge 5 commits into
base: website
Choose a base branch
from
Open

PR: Toolbar article #299

wants to merge 5 commits into from

Conversation

bbrennanbasis
Copy link
Contributor

This PR closes #237.

See webforj-docs-samples PR #97 for working samples.

@bbrennanbasis bbrennanbasis linked an issue Oct 30, 2024 that may be closed by this pull request
Document Toolbar Component #237
Open
MatthewHawkins
MatthewHawkins requested changes Oct 31, 2024
View reviewed changes
Copy link
Member

@MatthewHawkins MatthewHawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, I've made some requests - I'd move all of the mention of the AppLayout you have in here into its own section, where we can then demonstrate/use one of the applayout programs.

docs/components/toolbar.md Outdated Show resolved Hide resolved
docs/components/toolbar.md Outdated Show resolved Hide resolved
docs/components/toolbar.md Outdated Show resolved Hide resolved
docs/components/toolbar.md Outdated Show resolved Hide resolved
docs/components/toolbar.md Outdated Show resolved Hide resolved
MatthewHawkins
MatthewHawkins requested changes Nov 7, 2024
View reviewed changes
docs/components/toolbar.md Outdated Show resolved Hide resolved
docs/components/toolbar.md Outdated Show resolved Hide resolved
docs/components/toolbar.md Outdated Show resolved Hide resolved
docs/components/toolbar.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@hyyan hyyan Awaiting requested review from hyyan hyyan is a code owner

@MatthewHawkins MatthewHawkins Awaiting requested review from MatthewHawkins MatthewHawkins is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document Toolbar Component
2 participants
@bbrennanbasis @MatthewHawkins