-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cc-widgets): new cc-widgets UI using uuip web components. #349
base: ccwidgets
Are you sure you want to change the base?
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@@ -2,3 +2,16 @@ yarnPath: .yarn/releases/yarn-4.5.1.cjs | |||
checksumBehavior: update | |||
nodeLinker: node-modules | |||
npmRegistryServer: "https://registry.npmjs.org" | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Below npm registries can be removed, the main registry is uuip.
@@ -17,7 +17,10 @@ | |||
"test:unit": "jest" | |||
}, | |||
"dependencies": { | |||
"@momentum-ui/web-components": "2.16.6", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The below all three packages will be used to install for new UI using uuip
@@ -0,0 +1,23 @@ | |||
// This is used to let know typescript that the custom element is available in the global scope. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is used to let know typescript that the custom element is available in the global scope & typescript has no problem in using custom element that is uuip web component.
@@ -14,16 +16,27 @@ const StationLogin: React.FunctionComponent<StationLoginProps> = observer(({onLo | |||
const props = { | |||
...result, | |||
teams, | |||
loginOptions | |||
loginOptions, | |||
userRole: 'Agent', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added this to show, where we need to add uuip-wc-user-profile web component props.
<h3>This is the new CC Widget UI</h3> | ||
<div className="profile-settings"> | ||
<div className="user-profile-wrapper"> | ||
<uuip-wc-user-profile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The below is a dummy representation of the new CC Widget UI, the below required props can be extracted from the props object and passed to the uuip-cc-user-profile Web Component.
InitParams, | ||
IStore | ||
} from './store.types'; | ||
import {AgentLogin, IContactCenter, Profile, Team, WithWebex, InitParams, IStore} from './store.types'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The below are the prettier fix, on saving the file it fixes the prettier issues.
This PR completes [SPARK-584824] (https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-584824)
What does this PR adds?
Testing performed
Below is the SS of the new UI