Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only iterate over stores if stores exist #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cdjackson
Copy link

No description provided.

@bramski
Copy link

bramski commented Sep 4, 2014

hey @cdjackson this project is moving. https://github.com/bramski/angular-indexedDB

Can you add your PR and issue there? Thanks.

@cdjackson
Copy link
Author

Hi,
I certainly can, but there’s an issue. As your repo is behind the original one that I forked, if I create a PR you’ll get all the updates as well. I don’t see this is a problem - I guess you want to start with the latest, but before I do I wanted to make sure this was ok. Otherwise I’d have to cherry pick or something…

Cheers
Chris

On 4 Sep 2014, at 22:55, Bram Whillock [email protected] wrote:

hey @cdjackson this project is moving. https://github.com/bramski/angular-indexedDB

Can you add your PR and issue there? Thanks.


Reply to this email directly or view it on GitHub.

@corburn
Copy link

corburn commented Sep 5, 2014

@cdjackson the for loop will never run if storeNames is empty.

@cdjackson
Copy link
Author

It's been a few weeks since I looked at this, but I don't think it was the forEach loop that caused the problem I think it was the transaction call.
In any case, this DID cause an exception, and this DID fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants