Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build jsartoolkit5 with working emscripten #15

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

albjeremias
Copy link

@albjeremias albjeremias commented Oct 31, 2021

this makes possible to compile jsartoolkit5 using latest emscripten version

I removed the BINARYEN_TRAP_MODE=clamp cause it seems emscript does it by default!
stderr: emcc: error: Invalid command line option -s BINARYEN_TRAP_MODE=clamp: The wasm backend does not support a trap mode **(it always clamps, in effect)**

and the -r option is for .bc files to be supported by emscripten latest
emscripten-core/emscripten#13206 (comment)

@albjeremias albjeremias changed the title fix build bc files build jsartoolkit5 with latest emscript Oct 31, 2021
@albjeremias albjeremias changed the title build jsartoolkit5 with latest emscript WIP: build jsartoolkit5 with latest emscript Nov 1, 2021
@albjeremias
Copy link
Author

albjeremias commented Nov 1, 2021

^^

the fastcomp backend is not getting new builds or releases. Please use the upstream llvm backend or use an older version than 2.0.0 (such as 1.40.1)

when compiling without fastcomp.. the app crashes with "Out of memory".. well i can't compile with fastcomp.. so i guess its that..:s

@kalwalt
Copy link
Member

kalwalt commented Nov 2, 2021

^^

the fastcomp backend is not getting new builds or releases. Please use the upstream llvm backend or use an older version than 2.0.0 (such as 1.40.1)

when compiling without fastcomp.. the app crashes with "Out of memory".. well i can't compile with fastcomp.. so i guess its that..:s

Have you tried with the latest emsdk?
Take as reference JsartoolkitNFT for an updated makem.js and build instructions. Anyway i will test your changes when i can. I had always would switch to a newer emscripten version for jsartoolkit5...

@kalwalt kalwalt self-assigned this Nov 2, 2021
@kalwalt kalwalt added the enhancement New feature or request label Nov 2, 2021
@kalwalt kalwalt changed the title WIP: build jsartoolkit5 with latest emscript WIP: build jsartoolkit5 with latest emscripten Nov 10, 2021
@kalwalt
Copy link
Member

kalwalt commented Nov 10, 2021

The code is ok! Tested with emsdk 2.0.20 i will fix the conflicts and then i will merge it.

now we are using the official docker images from emsdk! :)
@albjeremias albjeremias changed the title WIP: build jsartoolkit5 with latest emscripten build jsartoolkit5 with working emscripten Nov 15, 2021
@albjeremias
Copy link
Author

albjeremias commented Nov 15, 2021

merged with master.. ready :)

@kalwalt
Copy link
Member

kalwalt commented Nov 15, 2021

merged with master.. ready :)

Thank you @albjeremias i will make a quick check/test soon!

@albjeremias
Copy link
Author

albjeremias commented Nov 15, 2021

I was not able to use the master branch.. it get:
#16

so i regressed to the commit: 4ed7e4b

and made the changes on the makem.js

please lets fix the regression before merging this. i will fill an issue

@kalwalt
Copy link
Member

kalwalt commented Nov 15, 2021

Ok i will wait. Just ping me when Is ready. 🙂

@albjeremias
Copy link
Author

Ok i will wait. Just ping me when Is ready. slightly_smiling_face

its ready...
maybe we can postpone solving the issue #16 ... but i now made a branch from the commits before zft...

@kalwalt kalwalt added the emscripten all about emscripten label Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emscripten all about emscripten enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants