Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dist path for minified builds in validator #7416

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

luu-alex
Copy link
Contributor

@luu-alex luu-alex commented Dec 4, 2024

Description

#6247
Currently when trying to import Web3Validator, it does not exist in react-native due to the dist not being available in the package. This PR includes the path to Web3Validator in the package.json.
Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (changes that only address relatively minor typographical errors are not accepted)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

Copy link

github-actions bot commented Dec 4, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 646.32 kB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
web3.min.js 627.37 kB 0%
../lib/commonjs/index.d.ts 8.72 kB 0%
../lib/commonjs/accounts.d.ts 3.19 kB 0%
../lib/commonjs/types.d.ts 2.73 kB 0%
../lib/commonjs/web3.d.ts 1.38 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.27 kB 0%
../lib/commonjs/abi.d.ts 1.14 kB 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: e3f79f4 Previous: 594f83a Ratio
processingTx 22045 ops/sec (±6.42%) 23821 ops/sec (±6.52%) 1.08
processingContractDeploy 39156 ops/sec (±8.09%) 38684 ops/sec (±8.01%) 0.99
processingContractMethodSend 15682 ops/sec (±7.75%) 15406 ops/sec (±8.61%) 0.98
processingContractMethodCall 27555 ops/sec (±6.74%) 27007 ops/sec (±7.65%) 0.98
abiEncode 42808 ops/sec (±8.06%) 43472 ops/sec (±7.00%) 1.02
abiDecode 31339 ops/sec (±6.62%) 30982 ops/sec (±6.75%) 0.99
sign 1551 ops/sec (±3.81%) 1524 ops/sec (±3.52%) 0.98
verify 367 ops/sec (±0.50%) 365 ops/sec (±0.65%) 0.99

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.54%. Comparing base (594f83a) to head (e3f79f4).
Report is 2 commits behind head on 4.x.

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #7416   +/-   ##
=======================================
  Coverage   94.54%   94.54%           
=======================================
  Files         218      218           
  Lines        8637     8637           
  Branches     2364     2364           
=======================================
  Hits         8166     8166           
  Misses        471      471           
Flag Coverage Δ
UnitTests 94.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@luu-alex luu-alex merged commit f41ca32 into 4.x Dec 10, 2024
54 checks passed
@luu-alex luu-alex deleted the fix-validator-react-native branch December 10, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants