-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dist path for minified builds in validator #7416
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: e3f79f4 | Previous: 594f83a | Ratio |
---|---|---|---|
processingTx |
22045 ops/sec (±6.42% ) |
23821 ops/sec (±6.52% ) |
1.08 |
processingContractDeploy |
39156 ops/sec (±8.09% ) |
38684 ops/sec (±8.01% ) |
0.99 |
processingContractMethodSend |
15682 ops/sec (±7.75% ) |
15406 ops/sec (±8.61% ) |
0.98 |
processingContractMethodCall |
27555 ops/sec (±6.74% ) |
27007 ops/sec (±7.65% ) |
0.98 |
abiEncode |
42808 ops/sec (±8.06% ) |
43472 ops/sec (±7.00% ) |
1.02 |
abiDecode |
31339 ops/sec (±6.62% ) |
30982 ops/sec (±6.75% ) |
0.99 |
sign |
1551 ops/sec (±3.81% ) |
1524 ops/sec (±3.52% ) |
0.98 |
verify |
367 ops/sec (±0.50% ) |
365 ops/sec (±0.65% ) |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7416 +/- ##
=======================================
Coverage 94.54% 94.54%
=======================================
Files 218 218
Lines 8637 8637
Branches 2364 2364
=======================================
Hits 8166 8166
Misses 471 471
Flags with carried forward coverage won't be shown. Click here to find out more. |
Description
#6247
Currently when trying to import Web3Validator, it does not exist in react-native due to the dist not being available in the package. This PR includes the path to Web3Validator in the package.json.
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.