-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade geth docker image #7380
base: 4.x
Are you sure you want to change the base?
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7380 +/- ##
=======================================
Coverage 94.54% 94.54%
=======================================
Files 218 218
Lines 8637 8637
Branches 2364 2364
=======================================
Hits 8166 8166
Misses 471 471
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: d4243eb | Previous: 926044b | Ratio |
---|---|---|---|
processingTx |
22035 ops/sec (±6.91% ) |
23218 ops/sec (±6.26% ) |
1.05 |
processingContractDeploy |
38620 ops/sec (±8.93% ) |
40127 ops/sec (±7.65% ) |
1.04 |
processingContractMethodSend |
15045 ops/sec (±7.90% ) |
16688 ops/sec (±8.68% ) |
1.11 |
processingContractMethodCall |
26791 ops/sec (±7.32% ) |
27967 ops/sec (±8.17% ) |
1.04 |
abiEncode |
41469 ops/sec (±7.40% ) |
43839 ops/sec (±7.60% ) |
1.06 |
abiDecode |
28406 ops/sec (±8.57% ) |
30802 ops/sec (±7.14% ) |
1.08 |
sign |
1472 ops/sec (±0.86% ) |
1526 ops/sec (±0.83% ) |
1.04 |
verify |
350 ops/sec (±3.03% ) |
363 ops/sec (±0.55% ) |
1.04 |
This comment was automatically generated by workflow using github-action-benchmark.
https://github.com/web3/web3.js/actions/runs/12122302708/job/33795271622 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, we need to change to the latest docker container version.
but it is a problem with tests: "missing trie node..." error
Upgrade geth to the latest version
Fixes #7379
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.