Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade geth docker image #7380

Open
wants to merge 2 commits into
base: 4.x
Choose a base branch
from
Open

chore: upgrade geth docker image #7380

wants to merge 2 commits into from

Conversation

krzysu
Copy link
Contributor

@krzysu krzysu commented Nov 8, 2024

Upgrade geth to the latest version

Fixes #7379

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

Copy link

github-actions bot commented Nov 8, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 646.32 kB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
web3.min.js 627.37 kB 0%
../lib/commonjs/index.d.ts 8.72 kB 0%
../lib/commonjs/accounts.d.ts 3.19 kB 0%
../lib/commonjs/types.d.ts 2.73 kB 0%
../lib/commonjs/web3.d.ts 1.38 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.27 kB 0%
../lib/commonjs/abi.d.ts 1.14 kB 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.54%. Comparing base (926044b) to head (d4243eb).

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #7380   +/-   ##
=======================================
  Coverage   94.54%   94.54%           
=======================================
  Files         218      218           
  Lines        8637     8637           
  Branches     2364     2364           
=======================================
  Hits         8166     8166           
  Misses        471      471           
Flag Coverage Δ
UnitTests 94.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: d4243eb Previous: 926044b Ratio
processingTx 22035 ops/sec (±6.91%) 23218 ops/sec (±6.26%) 1.05
processingContractDeploy 38620 ops/sec (±8.93%) 40127 ops/sec (±7.65%) 1.04
processingContractMethodSend 15045 ops/sec (±7.90%) 16688 ops/sec (±8.68%) 1.11
processingContractMethodCall 26791 ops/sec (±7.32%) 27967 ops/sec (±8.17%) 1.04
abiEncode 41469 ops/sec (±7.40%) 43839 ops/sec (±7.60%) 1.06
abiDecode 28406 ops/sec (±8.57%) 30802 ops/sec (±7.14%) 1.08
sign 1472 ops/sec (±0.86%) 1526 ops/sec (±0.83%) 1.04
verify 350 ops/sec (±3.03%) 363 ops/sec (±0.55%) 1.04

This comment was automatically generated by workflow using github-action-benchmark.

@luu-alex
Copy link
Contributor

luu-alex commented Dec 2, 2024

https://github.com/web3/web3.js/actions/runs/12122302708/job/33795271622
it looks like some test cases need to be updated after updating geth

Copy link
Contributor

@avkos avkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, we need to change to the latest docker container version.
but it is a problem with tests: "missing trie node..." error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Updates dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade geth used in the integration tests
3 participants