Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.14.0 #7333

Merged
merged 5 commits into from
Oct 21, 2024
Merged

v4.14.0 #7333

merged 5 commits into from
Oct 21, 2024

Conversation

luu-alex
Copy link
Contributor

Description

[4.14.0]

Added

web3-core

web3-eth

  • populateGasPrice function now checks Web3Context.config.ignoreGasPricing. If ignoreGasPricing is true, gasPrice will not be estimated (add ignoregaspricing config #7320)

Changed

web3

web3-eth

  • Allow getEthereumjsTxDataFrom to return additional fields that may be passed if using a customTransactionSchema.

web3-types

Fixed

web3-eth-abi

web3-utils

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

@luu-alex luu-alex marked this pull request as ready for review October 16, 2024 14:35
@luu-alex luu-alex changed the title bump versioning for 4.14.0 v4.14.0 Oct 16, 2024
Copy link

github-actions bot commented Oct 16, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 641.05 kB → 641.08 kB (+35 B) +0.01%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
../lib/commonjs/providers.exports.d.ts 148 B → 183 B (+35 B) +23.65%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
web3.min.js 621.56 kB 0%
../lib/commonjs/index.d.ts 8.72 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/web3.d.ts 1.38 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.28 kB 0%
../lib/commonjs/abi.d.ts 1.06 kB 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 068f4b6 Previous: 822f8c1 Ratio
processingTx 21275 ops/sec (±8.09%) 22958 ops/sec (±7.21%) 1.08
processingContractDeploy 36432 ops/sec (±6.61%) 40077 ops/sec (±7.24%) 1.10
processingContractMethodSend 15155 ops/sec (±8.08%) 15807 ops/sec (±8.02%) 1.04
processingContractMethodCall 26517 ops/sec (±8.14%) 27362 ops/sec (±8.03%) 1.03
abiEncode 40358 ops/sec (±7.14%) 44555 ops/sec (±6.70%) 1.10
abiDecode 29088 ops/sec (±7.36%) 30694 ops/sec (±6.83%) 1.06
sign 1508 ops/sec (±0.70%) 1590 ops/sec (±1.37%) 1.05
verify 360 ops/sec (±0.61%) 365 ops/sec (±0.53%) 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

github-actions bot commented Oct 16, 2024

Benchmark

Benchmark suite Current: 068f4b6 Previous: 822f8c1 Ratio
processingTx 23498 ops/sec (±6.52%) 22958 ops/sec (±7.21%) 0.98
processingContractDeploy 40396 ops/sec (±7.19%) 40077 ops/sec (±7.24%) 0.99
processingContractMethodSend 16527 ops/sec (±8.65%) 15807 ops/sec (±8.02%) 0.96
processingContractMethodCall 28169 ops/sec (±7.57%) 27362 ops/sec (±8.03%) 0.97
abiEncode 44497 ops/sec (±7.09%) 44555 ops/sec (±6.70%) 1.00
abiDecode 30277 ops/sec (±8.40%) 30694 ops/sec (±6.83%) 1.01
sign 1523 ops/sec (±3.06%) 1590 ops/sec (±1.37%) 1.04
verify 371 ops/sec (±0.40%) 365 ops/sec (±0.53%) 0.98

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

cloudflare-workers-and-pages bot commented Oct 16, 2024

Deploying web3-js-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 068f4b6
Status: ✅  Deploy successful!
Preview URL: https://76649211.web3-js-docs.pages.dev
Branch Preview URL: https://head.web3-js-docs.pages.dev

View logs

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.45%. Comparing base (69187c5) to head (068f4b6).
Report is 2 commits behind head on 4.x.

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #7333   +/-   ##
=======================================
  Coverage   94.45%   94.45%           
=======================================
  Files         216      216           
  Lines        8469     8470    +1     
  Branches     2341     2341           
=======================================
+ Hits         7999     8000    +1     
  Misses        470      470           
Flag Coverage Δ
UnitTests 94.45% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants