Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update canary node version #7142

Merged
merged 4 commits into from
Jul 8, 2024
Merged

update canary node version #7142

merged 4 commits into from
Jul 8, 2024

Conversation

luu-alex
Copy link
Contributor

@luu-alex luu-alex commented Jul 8, 2024

Description

Running into invalid node version


error @ethereumjs/[email protected]: The engine "node" is incompatible with this module. Expected version ">=18". Got "16.20.2"
error Found incompatible module.

updates node version
Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

Copy link

github-actions bot commented Jul 8, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 635.51 kB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
web3.min.js 616.22 kB 0%
../lib/commonjs/index.d.ts 8.69 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/web3.d.ts 1.35 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.2 kB 0%
../lib/commonjs/abi.d.ts 999 B 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 7f195c4 Previous: 38fac06 Ratio
processingTx 8715 ops/sec (±4.20%) 8674 ops/sec (±4.68%) 1.00
processingContractDeploy 39116 ops/sec (±6.09%) 40592 ops/sec (±6.80%) 1.04
processingContractMethodSend 15066 ops/sec (±9.15%) 16400 ops/sec (±6.88%) 1.09
processingContractMethodCall 27094 ops/sec (±6.29%) 27278 ops/sec (±7.84%) 1.01
abiEncode 42336 ops/sec (±7.01%) 45234 ops/sec (±7.24%) 1.07
abiDecode 29510 ops/sec (±8.43%) 31124 ops/sec (±7.73%) 1.05
sign 1488 ops/sec (±3.07%) 1589 ops/sec (±0.76%) 1.07
verify 370 ops/sec (±0.67%) 369 ops/sec (±2.66%) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.45%. Comparing base (59e67bf) to head (7f195c4).
Report is 1 commits behind head on 4.x.

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #7142   +/-   ##
=======================================
  Coverage   94.45%   94.45%           
=======================================
  Files         215      215           
  Lines        8387     8390    +3     
  Branches     2313     2313           
=======================================
+ Hits         7922     7925    +3     
  Misses        465      465           
Flag Coverage Δ
UnitTests 94.45% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@luu-alex luu-alex changed the title update canary update canary node version Jul 8, 2024
@luu-alex luu-alex merged commit 1436228 into 4.x Jul 8, 2024
21 checks passed
@luu-alex luu-alex deleted the fix-canary branch July 8, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants