Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update doc navbar, so guides isn't always active #6682

Closed
wants to merge 1 commit into from

Conversation

luu-alex
Copy link
Contributor

@luu-alex luu-alex commented Jan 3, 2024

Description

Screenshot 2024-01-03 at 1 29 40 PM

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

Copy link

github-actions bot commented Jan 3, 2024

Bundle Stats

Hey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Asset Old size New size Diff Diff %
Total 591 KB 591 KB 0 0.00%
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset Old size New size Diff Diff %
web3.min.js 573 KB 573 KB 0 0.00%
../lib/commonjs/index.d.ts 8.63 KB 8.63 KB 0 0.00%
../lib/commonjs/accounts.d.ts 3.89 KB 3.89 KB 0 0.00%
../lib/commonjs/types.d.ts 2.45 KB 2.45 KB 0 0.00%
../lib/commonjs/web3.d.ts 1.14 KB 1.14 KB 0 0.00%
../lib/commonjs/abi.d.ts 999 bytes 999 bytes 0 0.00%
../lib/commonjs/eth.exports.d.ts 280 bytes 280 bytes 0 0.00%
../lib/commonjs/providers.exports.d.ts 148 bytes 148 bytes 0 0.00%
../lib/commonjs/version.d.ts 60 bytes 60 bytes 0 0.00%

Copy link

github-actions bot commented Jan 3, 2024

Benchmark

Benchmark suite Current: 4e9522f Previous: 6c075db Ratio
processingTx 9447 ops/sec (±4.50%) 9301 ops/sec (±4.81%) 0.98
processingContractDeploy 40275 ops/sec (±6.62%) 39129 ops/sec (±7.62%) 0.97
processingContractMethodSend 20234 ops/sec (±6.34%) 19443 ops/sec (±5.19%) 0.96
processingContractMethodCall 40149 ops/sec (±5.13%) 38971 ops/sec (±6.34%) 0.97
abiEncode 46584 ops/sec (±6.61%) 44252 ops/sec (±6.92%) 0.95
abiDecode 32415 ops/sec (±7.36%) 30419 ops/sec (±8.89%) 0.94
sign 1611 ops/sec (±3.11%) 1656 ops/sec (±4.08%) 1.03
verify 387 ops/sec (±0.51%) 373 ops/sec (±0.78%) 0.96

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Merging #6682 (4e9522f) into 4.x (a4f2f8c) will increase coverage by 0.43%.
Report is 59 commits behind head on 4.x.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##              4.x    #6682      +/-   ##
==========================================
+ Coverage   91.03%   91.46%   +0.43%     
==========================================
  Files         214      214              
  Lines        8117     8155      +38     
  Branches     2172     2193      +21     
==========================================
+ Hits         7389     7459      +70     
+ Misses        728      696      -32     
Flag Coverage Δ
UnitTests 91.46% <ø> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

Copy link

github-actions bot commented Mar 4, 2024

This PR has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.

@github-actions github-actions bot added the Stale Has not received enough activity label Mar 4, 2024
@github-actions github-actions bot closed this Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Has not received enough activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant