[Docs] Guides & Tutorials improvement #6676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I see that every single quot has been changed to double quot. Like import { Web3PluginBase } from 'web3'; is changed to import { Web3PluginBase } from "web3";.
There is no right or wrong here. But this is not our coding-style. And if we copy code from our code base it will be single quot always. As if we write double quot in our code, our prettifier configuration will change it to single quot.
So, could you please revert back to single quotes?
Thanks,
|
@Muhammad-Altabba Thanks for the heads up, I just changed it in the last commit. |
jdevcs
approved these changes
Jan 5, 2024
Co-authored-by: Muhammad Altabba <[email protected]>
Co-authored-by: Muhammad Altabba <[email protected]>
Muhammad-Altabba
approved these changes
Jan 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi guys, I made some major changes in the structure of the categories (folders and files), rewrote some texts, fixed some typos, cleaned some code (formatting), added some other code samples, added some things(e.g, wallet, and accounts section) and created the
Getting startedguide, also I removed the glossary in the sidebar and added it to theguides and tutorialspart.Feel free to go to the branch
guides_improvementand runyarn startto see in the local environment all the changes.I didn't change the
events subscriptionfolder at all since I wasn't able to follow the guide/interact with logs.