Release/4.3.0 #6630
Release/4.3.0 #6630
Conversation
luu-alex
requested review from
avkos,
jdevcs and
Muhammad-Altabba
as code owners
Deploying with
|
| Latest commit: |
b9b5fe0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3115dfed.web3-js-docs.pages.dev |
| Branch Preview URL: | https://release-4-3-0.web3-js-docs.pages.dev |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6630 +/- ##
==========================================
+ Coverage 89.44% 89.85% +0.41%
==========================================
Files 215 215
Lines 8296 8297 +1
Branches 2241 2241
==========================================
+ Hits 7420 7455 +35
+ Misses 876 842 -34
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
|
|
||
| ### Changed | ||
|
|
||
| - Dependencies updated |
There was a problem hiding this comment.
if there are only patch & minor dep updates we can skip changes in these packages,
There was a problem hiding this comment.
skipped packages that are only patch/minor dep updates
|
also could you see reason of failing integration tests in geth |
|
sepolia, mainnet and geth estimategas function tests are failing. This has been occuring for mainnet and sepolia for a while but is quite new for geth estimate_gas function to be failing |
I think |
There was a problem hiding this comment.
Could you please double check the errors. There is this error in the unit lint, for example:
web3-core: 27:1 error 'web3-providers-ws' should be listed in the project's dependencies. Run 'npm i -S web3-providers-ws' to add it import/no-extraneous-dependencies
And this at the E2E Network Tests (http, mainnet):
FAIL test/e2e/get_proof.test.ts
● sepolia tests - getProof › getProof
expect(received).toMatchObject(expected)
- Expected - 1
+ Received + 0
@@ -1,7 +1,6 @@
Object {
- "accountProof": Any<Array>,
"balance": Any<BigInt>,
"codeHash": Any<String>,
"nonce": Any<BigInt>,
"storageHash": Any<String>,
"storageProof": Any<Array>,
70 | expect(result).toEqual(expectedProof);
71 | } else {
> 72 | expect(result).toMatchObject<AccountObject>({
| ^
73 | accountProof: expect.any(Array<string>),
74 | balance: expect.any(BigInt),
75 | codeHash: expect.any(String),
at test/e2e/get_proof.test.ts:72:19
at fulfilled (test/e2e/get_proof.test.ts:22:58)
|
@Muhammad-Altabba fixed both, thank you |
There was a problem hiding this comment.
Could you please create an issue for the failing tests: https://github.com/web3/web3.js/actions/runs/7091989375/job/19302456686?pr=6630
Many thanks,
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.