-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/4.2.2 #6562
Release/4.2.2 #6562
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6562 +/- ##
==========================================
+ Coverage 87.37% 89.56% +2.19%
==========================================
Files 197 215 +18
Lines 7548 8251 +703
Branches 2059 2234 +175
==========================================
+ Hits 6595 7390 +795
+ Misses 953 861 -92
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
https://github.com/web3/web3.js/actions/runs/6732417536/job/18299078974 deploy failing, looks like an auth issue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except @luu-alex comments
we can fix it in another PR
Its passing now, was due to some validation unit tests consuming more time, |
[4.2.2]
Added
web3-core
isMetaMaskProvider
function to check if provider is metamask (metamask eth_sendtransaction broken #6534)web3-types
MetaMaskProvider
added and is part ofSupportedProviders
(metamask eth_sendtransaction broken #6534)gasPrice
was added toTransaction1559UnsignedAPI
type. (Fix TransactionInfoAPI type #6539)Changed
web3
Fixed
web3-errors
transactionTimeoutHint
(Fix grammar and spelling #6559)web3-eth-contract
data
for transactions in contract for metamask provider instead ofinput
(metamask eth_sendtransaction broken #6534)