Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getTransaction.gasPrice return type fix #6492

Closed
wants to merge 3 commits into from
Closed

getTransaction.gasPrice return type fix #6492

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
887eb21
getTransaction.gasPrice return type fix
neerajsingh34 Oct 10, 2023
978b873
Merge branch '4.x' into fix/getTransactionTypes
neerosity Oct 10, 2023
4a85068
Merge branch '4.x' into fix/getTransactionTypes
Muhammad-Altabba Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/web3-types/src/eth_types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ export type TransactionOutput = {
readonly from?: HexString;
readonly input: string;
readonly gas?: Numbers;
readonly gasPrice?: Numbers;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will not fix issue, this type is used in formatter functions and those formatters are only for backward compatibility.

readonly gasLimit?: string;
readonly nonce: Numbers;
readonly value: Numbers;
Expand Down