Skip to content

Commit

Permalink
Export EIP-6963 Types (#7270)
Browse files Browse the repository at this point in the history
* Export EIP-6963 Types

* CHANGELOG

* Comments from Review
  • Loading branch information
danforbes authored Oct 9, 2024
1 parent facc2e6 commit f701406
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2740,3 +2740,7 @@ If there are any bugs, improvements, optimizations or any new feature proposal f
#### web3-eth

- Allow `getEthereumjsTxDataFrom` to return additional fields that may be passed if using a `customTransactionSchema`.

#### web3

- Exported EIP-6963 types are no longer under the `providers` namespace. (#7270)
1 change: 1 addition & 0 deletions packages/web3/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,7 @@ along with web3.js. If not, see <http://www.gnu.org/licenses/>.
import Web3 from './web3.js';

export * from './types.js';
export * from './web3_eip6963.js';
export default Web3;

/**
Expand Down
1 change: 0 additions & 1 deletion packages/web3/src/providers.exports.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,3 @@ export { Eip1193Provider, SocketProvider } from 'web3-utils';

export * as http from 'web3-providers-http';
export * as ws from 'web3-providers-ws';
export * from './web3_eip6963.js';

1 comment on commit f701406

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: f701406 Previous: facc2e6 Ratio
processingTx 22830 ops/sec (±7.43%) 22984 ops/sec (±5.69%) 1.01
processingContractDeploy 39939 ops/sec (±7.35%) 38640 ops/sec (±12.90%) 0.97
processingContractMethodSend 15792 ops/sec (±6.76%) 16387 ops/sec (±6.56%) 1.04
processingContractMethodCall 27711 ops/sec (±6.25%) 28396 ops/sec (±6.55%) 1.02
abiEncode 42219 ops/sec (±7.33%) 44603 ops/sec (±6.87%) 1.06
abiDecode 29744 ops/sec (±7.55%) 32125 ops/sec (±5.97%) 1.08
sign 1498 ops/sec (±3.49%) 1562 ops/sec (±3.66%) 1.04
verify 365 ops/sec (±0.60%) 369 ops/sec (±0.44%) 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.