Skip to content

Commit

Permalink
remove redundant constructor of ContractBuilder (#7150)
Browse files Browse the repository at this point in the history 
Co-authored-by: Oleksii Kosynskyi <[email protected]>
  • Loading branch information
@agj017 @avkos
agj017 and avkos authored Jul 22, 2024
1 parent 5ad7e5b commit cbcfc18
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions packages/web3/src/web3.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -137,12 +137,6 @@ export class Web3<
optionsOrContextOrReturnFormat?: ContractInitOptions,
contextOrReturnFormat?: Web3Context | DataFormat,
);
public constructor(
jsonInterface: Abi,
addressOrOptionsOrContext?: Address | ContractInitOptions,
optionsOrContextOrReturnFormat?: ContractInitOptions,
contextOrReturnFormat?: Web3Context | DataFormat,
);
public constructor(
jsonInterface: Abi,
addressOrOptionsOrContext?: Address | ContractInitOptions,
Expand Down

1 comment on commit cbcfc18

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: cbcfc18 Previous: 5ad7e5b Ratio
processingTx 9153 ops/sec (±4.31%) 9148 ops/sec (±3.95%) 1.00
processingContractDeploy 40380 ops/sec (±6.17%) 39275 ops/sec (±7.28%) 0.97
processingContractMethodSend 16446 ops/sec (±6.81%) 15230 ops/sec (±9.01%) 0.93
processingContractMethodCall 27283 ops/sec (±7.60%) 26302 ops/sec (±8.43%) 0.96
abiEncode 46030 ops/sec (±6.70%) 41324 ops/sec (±6.98%) 0.90
abiDecode 30377 ops/sec (±7.33%) 30233 ops/sec (±6.38%) 1.00
sign 1557 ops/sec (±0.83%) 1496 ops/sec (±3.87%) 0.96
verify 371 ops/sec (±0.36%) 362 ops/sec (±0.73%) 0.98

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.