-
Notifications
You must be signed in to change notification settings - Fork 5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(validator): generate abi name if not provided (#6981)
* fix(validator): generate abi name if not provided In the case of public mappings, the ABI generated has a blank name set. This results in blank ids for such inputs within the JSON schema. Post 1f81ff0, the number of unique ids is used to convert the JSON scheme into Zod, and hence the presence of blank ids is a concern. This commit generates the `abiName` if one is not provided to a value equal to the `${level}/${index}`. Fixes #6965. * fix: add validator changes to root CHANGELOG --------- Co-authored-by: Alex <[email protected]>
- Loading branch information
1 parent
d4e937d
commit 53e2466
Showing
4 changed files
with
37 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53e2466
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
processingTx
9238
ops/sec (±4.05%
)9301
ops/sec (±4.81%
)1.01
processingContractDeploy
40322
ops/sec (±6.08%
)39129
ops/sec (±7.62%
)0.97
processingContractMethodSend
19715
ops/sec (±7.38%
)19443
ops/sec (±5.19%
)0.99
processingContractMethodCall
40521
ops/sec (±5.96%
)38971
ops/sec (±6.34%
)0.96
abiEncode
46271
ops/sec (±6.29%
)44252
ops/sec (±6.92%
)0.96
abiDecode
31281
ops/sec (±8.11%
)30419
ops/sec (±8.89%
)0.97
sign
1603
ops/sec (±3.79%
)1656
ops/sec (±4.08%
)1.03
verify
379
ops/sec (±0.42%
)373
ops/sec (±0.78%
)0.98
This comment was automatically generated by workflow using github-action-benchmark.