Update to use electra version of go-eth2-client #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcdee
reviewed
Jan 27, 2025
cmd/block/analyze/process.go
Outdated
| @@ -63,8 +63,12 @@ func (c *command) process(ctx context.Context) error { | |||
| // Calculate how many parents we need to fetch. | |||
| minSlot := slot | |||
| for _, attestation := range attestations { | |||
| if attestation.Data.Slot < minSlot { | |||
| minSlot = attestation.Data.Slot | |||
| attestData, err := attestation.Data() | |||
There was a problem hiding this comment.
Is there a reason to use attestData here rather than the expected attestationData that you have used elsewhere?
There was a problem hiding this comment.
Yes there is an attestationData struct in this package that causes a conflict.
I can rename the struct to something like attestationDataInfo and make the variables consistent if you prefer?
There was a problem hiding this comment.
Yeah it jarred when reading it, so tweaking the name of the struct and standardising the variable name makes sense here.
mcdee
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.