refactor(admin): validation rules in PostsController

weDevsOfficial · Mar 19, 2024 · ec8250d · ec8250d
1 parent 17ef441
commit ec8250d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/app/Http/Controllers/Admin/PostsController.php b/app/Http/Controllers/Admin/PostsController.php
@@ -10,13 +10,18 @@ class PostsController extends Controller
 {
     public function store(Request $request)
     {
-        $request->validate([
+        $rules = [
             'title' => 'required',
             'body' => 'required',
             'status_id' => 'required|exists:statuses,id',
             'board_id' => 'required|exists:boards,id',
-            'behalf_id' => 'sometimes|exists:users,id',
-        ]);
+        ];
+
+        if ($request->has('behalf_id') && $request->behalf_id) {
+            $rules['behalf_id'] = 'exists:users,id';
+        }
+
+        $request->validate($rules);
 
         $args = [
             'title' => $request->title,

diff --git a/resources/js/Pages/Admin/Feedbacks/Create.tsx b/resources/js/Pages/Admin/Feedbacks/Create.tsx
@@ -47,7 +47,7 @@ const CreateModal = ({
     body: '',
     board_id: '',
     status_id: '',
-    behalf_id: 0,
+    behalf_id: null,
   });
 
   const statusOptions = statuses.map((status) => ({
@@ -92,7 +92,7 @@ const CreateModal = ({
                 setBehalfUser(user);
                 form.setData('behalf_id', user.id);
               }}
-              onClear={() => form.setData('behalf_id', 0)}
+              onClear={() => form.setData('behalf_id', null)}
             />
           </div>