fix: 修改span finish 异常记录

we7coreteam · Jul 13, 2021 · e25a7c5 · e25a7c5
1 parent 1433c52
commit e25a7c5
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/src/TracerSpanTrait.php b/src/TracerSpanTrait.php
@@ -67,7 +67,15 @@ protected function getSpan(string $spanName = 'server', string $kind = 'server',
 	protected function finishSpan(Span $span) {
 		$contextKey = 'opentracing.tracer.span.' . $span->getOperationName() . '.' . $span->getContext()->getBaggageItem('x-span-kind') . '.' . $span->getContext()->getBaggageItem('x-span-tracer');
 		$this->getContext()->setContextDataByKey($contextKey, null);
-		$span->finish();
+		try {
+			$span->finish();
+		} catch (\Throwable $e) {
+			/**
+			 * @var HandlerExceptions $exceptionHandler
+			 */
+			$exceptionHandler = $this->getContainer()->get(HandlerExceptions::class);
+			$exceptionHandler->getHandler()->report($e);
+		}
 	}
 
 	protected function makeSpan($traceName, $spanName, $kind) {