Fix test RestStatusTests.testStatusReturnsFailureStatusWhenFailuresEx…

…ist (opensearch-project#15011) This test has a reproducible failure when the highest "failure" status is 100 level. This happens because RestStatus.status treats these as OK. Signed-off-by: Marc Handalian <[email protected]>
wdongyu · Aug 22, 2024 · e67b9e1 · e67b9e1
1 parent d99e0e0
commit e67b9e1
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/server/src/test/java/org/opensearch/core/RestStatusTests.java b/server/src/test/java/org/opensearch/core/RestStatusTests.java
@@ -55,7 +55,11 @@ public void testStatusReturnsFailureStatusWhenFailuresExist() {
             heapOfFailures.add(failure);
         }
 
-        assertEquals(heapOfFailures.peek().status(), RestStatus.status(successfulShards, totalShards, failures));
+        final RestStatus status = heapOfFailures.peek().status();
+        // RestStatus.status will return RestStatus.OK when the highest failure code is 100 level.
+        final RestStatus expected = status.getStatusFamilyCode() == 1 ? RestStatus.OK : status;
+
+        assertEquals(expected, RestStatus.status(successfulShards, totalShards, failures));
     }
 
     public void testSerialization() throws IOException {