Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better typing for tokens #49

Merged
merged 2 commits into from
Jan 24, 2024
Merged

better typing for tokens #49

merged 2 commits into from
Jan 24, 2024

Conversation

wcho21
Copy link
Owner

@wcho21 wcho21 commented Jan 24, 2024

refactor

  • SourceTokenBase: factor out common fields of token types into generic
  • SourceTokenBase: now token objects have its range in separate range field
  • createTokenCreator: factor out token creating logic as a generic function

testing

  • test token creator functions

@wcho21 wcho21 self-assigned this Jan 24, 2024
@wcho21 wcho21 merged commit 1e0b789 into dev Jan 24, 2024
1 check passed
@wcho21 wcho21 deleted the feat branch January 24, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant