Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up dashboard cards #926

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

AndrewKostka
Copy link
Contributor

@AndrewKostka AndrewKostka commented Nov 18, 2024

Bug: T373129
Bug: T359530

Copy link

Deployment previews on netlify for branch refs/pull/926/merge will be at the following locations (when build is done):

@rosalieper
Copy link
Contributor

The delete wikibase card has become smaller (shrink). I did not see that in accepted criteria.

Copy link
Contributor

@dati18 dati18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good to go

padding: 8px;
}
.tab-container >>> .col {
max-width: 740px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Charlie's request, this should be 640px

Suggested change
max-width: 740px;
max-width: 640px;

Copy link
Contributor

@dati18 dati18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

896px for FEATURES cards also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants