update to use AWS Signature Version 4 #174
Conversation
|
I'd love to see this merged into s3_direct_upload gem. New buckets only work with v4 policy. |
|
Seems like this would only work with |
|
@hakunin what do you mean? You can configure your region in the configurator. |
|
I am not an expert at s3, but this part seems hardcoded just for one region, shouldn't it match all the new ones or something? |
|
It's how Amazon decided to name their servers. Have a look at their site (scroll down to Amazon Simple Storage Service) and see how the region name and endpoints are related. The code you pointed out just follows this (weird) rule. |
|
Thanks for clarifying that @lenart, I just checked out Matt's fork and can verify that this works. Would be nice if this was merged after so many months, or if a fork could be made to carry on the awesome direct_s3 gem's functionality. |
|
I think alot of people are using this in forks. I'd like to see a solution for this problem merged. This shouldn't break any existing apps right? |
| @@ -16,7 +16,7 @@ def initialize(options) | |||
| aws_access_key_id: S3DirectUpload.config.access_key_id, | |||
| aws_secret_access_key: S3DirectUpload.config.secret_access_key, | |||
| bucket: options[:bucket] || S3DirectUpload.config.bucket, | |||
| region: S3DirectUpload.config.region || "s3", | |||
| region: S3DirectUpload.config.region || "us-east-1", | |||
There was a problem hiding this comment.
Should us-east-1 be the default?
|
I can't see that this has been implemented yet? |
based on pr waynehoover/s3_direct_upload#174 made by @mattwarrenrnp
this is a rewrite of the form helper to implement the current AWS Signature version 4 method of signing the policy.