Fix SchemaField description

CHANGELOG.md

@@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.0.5] - 2024-07-30
+
+### Changed
+- Fixed get_bq_schema_from_json_schema() SchemaField parameters
+
 ## [Unreleased]
 
 ### Internal
@@ -12,7 +17,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [1.0.4] - 2023-10-24
 
-## Changed
+### Changed
 - Upgrade to Pydantic V2
 
 ## [1.0.2] - 2023-10-10

gbq/helpers.py

@@ -36,10 +36,10 @@ def get_bq_schema_from_json_schema(source: List[Dict]) -> List[SchemaField]:
 
     for key, value in enumerate(source):
         schema_field = SchemaField(
-            str(value.get("name")),
-            str(value.get("type")),
-            value.get("mode", "NULLABLE"),
-            value.get("description", None),
+            name=str(value.get("name")),
+            field_type=str(value.get("type")),
+            mode=value.get("mode", "NULLABLE"),
+            description=value.get("description", None),
         )
 
         # Add the field to the list of fields

pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "gbq"
-version = "1.0.4"
+version = "1.0.5"
 description = "Python wrapper for interacting Google BigQuery."
 readme = "README.md"
 license = {text = "MIT"}

tests/fixtures.py

@@ -73,12 +73,23 @@ def nested_json_schema():
         {"name": "username", "mode": "NULLABLE", "type": "STRING"},
         {
             "fields": [
-                {"name": "id", "mode": "NULLABLE", "type": "INTEGER"},
-                {"name": "street", "mode": "NULLABLE", "type": "STRING"},
+                {
+                    "name": "id",
+                    "mode": "NULLABLE",
+                    "type": "INTEGER",
+                    "description": "ID DESCRIPTION",
+                },
+                {
+                    "name": "street",
+                    "mode": "NULLABLE",
+                    "type": "STRING",
+                    "description": "STREET DESCRIPTION",
+                },
             ],
             "name": "address",
             "mode": "REPEATED",
             "type": "RECORD",
+            "description": "ADDRESS DESCRIPTION",
         },
     ]
 

tests/test_helpers.py

@@ -42,10 +42,12 @@ def test_get_bq_credentials(mocker):
 
 
 def test_convert_to_bq_schema(nested_json_schema):
-    address_schema = SchemaField("address", "RECORD", "REPEATED")
+    address_schema = SchemaField(
+        "address", "RECORD", "REPEATED", None, "ADDRESS DESCRIPTION"
+    )
     address_nested_schema = [
-        SchemaField("id", "INTEGER", "NULLABLE"),
-        SchemaField("street", "STRING", "NULLABLE"),
+        SchemaField("id", "INTEGER", "NULLABLE", None, "ID DESCRIPTION"),
+        SchemaField("street", "STRING", "NULLABLE", None, "STREET DESCRIPTION"),
     ]
     address_schema._fields = address_nested_schema
     expected = [