Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gpu: Also mount card node #676

Merged
merged 1 commit into from
Jan 12, 2023
Merged

gpu: Also mount card node #676

merged 1 commit into from
Jan 12, 2023

Conversation

aleasto
Copy link
Member

@aleasto aleasto commented Jan 5, 2023

Necessary for minigbm_gbm_mesa

@aleasto
gpu: Also mount card node
ef98579 
Necessary for minigbm_gbm_mesa
@aleasto
Copy link
Member Author

aleasto commented Jan 5, 2023

I can't remember why i hadn't pushed this

@JamiKettunen
Copy link
Contributor

Cool, what does minigbm_gbm_mesa bring us? I saw at least one issue about it making some game work: #589

@Quackdoc
Copy link
Contributor

Quackdoc commented Jan 8, 2023

does it need it? works fine for me on AMD RX580 without it. is this an intel gpu thing?

Either way no complaints from me if it's necessary.

@aleasto
Copy link
Member Author

aleasto commented Jan 8, 2023

https://github.com/waydroid/android_external_minigbm/blob/lineage-18.1/gbm_mesa_driver/gbm_mesa_internals.cpp#L204

An explanation can be found here: robherring/gbm_gralloc#16

@Quackdoc
Copy link
Contributor

Quackdoc commented Jan 8, 2023

ahh I see,

@aleasto aleasto merged commit 27b99dd into waydroid:main Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aleasto @JamiKettunen @Quackdoc