hwcomposer: refactor hwc_set into smaller functions #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DakeuTaepi
force-pushed
the
lineage-18.1-refactor
branch
2 times, most recently
from
389b9e8
to
47e1b46
Compare
maciek134
reviewed
Oct 21, 2022
maciek134
reviewed
Oct 21, 2022
DakeuTaepi
force-pushed
the
lineage-18.1-refactor
branch
from
47e1b46
to
380cb5e
Compare
aleasto
requested changes
Oct 29, 2022
There was a problem hiding this comment.
Thank you for the contribution.
Regressions found on my end (kwin_wayland 5.26.2):
- Background in multi-windows mode is not transparent anymore
- The
persist.waydroid.cursor_on_subsurfacehack for showing the cursor on kwin_wayland in multi-windows mode doesn't work anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set() is a HWComposer HAL method which gets called when SurfaceFlinger is ready to present its layers on screen (https://android.googlesource.com/platform/hardware/libhardware/+/master/include/hardware/hwcomposer.h#531). Waydroid seems to use it as main place to hijack rendering and map SurfaceFlinger layers (with extra metadata like task ID/app ID added) to Wayland windows.
Unfortunately, because there at least 3 different windowing modes supported (render Android screen in a single window, create a distinct Android screen window per app, and desktop free-form multi-window mode), the hwc_set functions looks pretty convoluted and hard to extend/modify.
I've attempted to slim it down a bit by separating code chunks to make hwc_set() easier to read, but not quite happy with the result yet. Maybe someone else would have a better idea how to split it up after reading the code, so any feedback would be welcome.