Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'transferTransactionById' in Ride. #1274

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

nickeskov
Copy link
Member

Now function returns transaction only if transfer is regular or ethereum transfer transaction. Otherwise it returns 'unit'.

Now function returns transaction only if transfer is regular or ethereum
transfer transaction. Otherwise it returns 'unit'.
@nickeskov nickeskov added bug Something isn't working do not merge The PR is not ready to be merged labels Dec 14, 2023
@nickeskov nickeskov removed the do not merge The PR is not ready to be merged label Dec 14, 2023
@alexeykiselev alexeykiselev merged commit 0d7b1b4 into master Dec 14, 2023
15 checks passed
@alexeykiselev alexeykiselev deleted the fix-ride-transfer-transaction-by-id branch December 14, 2023 08:53
nickeskov added a commit that referenced this pull request Dec 14, 2023
nickeskov added a commit that referenced this pull request Dec 14, 2023
* Add test and bugfix for 'transferTransactionByID'.

Continuation of #1274.

* Remove unnecessary code in 'TestTransferByID'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants