Tests on correct scopes handling by estimator and evaluator added. #1264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Few compilation errors of FOLD fixed. Comparison of Any type to other types fixed in compilation.
alexeykiselev
added
do not merge
nickeskov
requested changes
Dec 8, 2023
Fixed SimpeType Equal function.
nickeskov
approved these changes
Dec 14, 2023
alexeykiselev
added a commit
that referenced
this pull request
Jan 10, 2024
* Ride V8 library version added. Tests updated. * Replaced map initialization with for cycle. * Some BigInt functions revaluated. Function removeByIndex revaluated. (#1256) * Add attachment field in order (#1140) * add attachment field in order * fix tests * Add more info to the error message. Refactor a bit 'TestAttachmentInOrder'. * add new feature and ride v8 for attachment in order * Correct features order ('TransactionStateSnapshot' == 22). * Bound exising logic to 'TransactionStateSnapshot' feature (version 1.5.0) according to the NODE-2531 task. * fix sign for order with attachment * fix issues and add tests * fix linters issues * create type for order's version * add test for order with rideV8 * Replace type alias with type for OrderVersion. * Type of the attachment in the Ride Order type updated to "ByteVector|Unit". * Old feature naming removed. Existing function Size of Attachement used to check the length of order's attachement. * Comments fixed. Obsolete TODO removed. --------- Co-authored-by: Nikolay Eskov <[email protected]> Co-authored-by: Alexey Kiselev <[email protected]> * Ride function replaceByIndex implemented and tested. (#1257) * Ride function replaceByIndex implemented and tested. * Arguments checks of list functions replaced by call to checkArgs function. Constant moved to function where it used. Functions max and min renamed to listMax and listMin because of the collision with built-in functions. * CalculateDelay Ride function implemented and partially tested. (#1259) * CalculateDelay Ride function implemented and partially tested. * Funciton calculateDelay updated according to new specification. Tests added. * Irrelevant comment removed. New function ID fixed. * Tests on correct scopes handling by estimator and evaluator added. (#1264) * Tests on correct scopes handling by estimator and evaluator added. Few compilation errors of FOLD fixed. Comparison of Any type to other types fixed in compilation. * Added test on FOLD compilation. Fixed SimpeType Equal function. * Deactivation of Ride versions 1, 2 and 3 on Light Node feature activation implemented. (#1278) Test added. --------- Co-authored-by: Anton Ilin <[email protected]> Co-authored-by: Nikolay Eskov <[email protected]>
alexeykiselev
added a commit
that referenced
this pull request
Apr 12, 2024
* Light Node feature added. * Ride V8 library version added. Tests updated. (#1255) * Ride V8 library version added. Tests updated. * Replaced map initialization with for cycle. * Some BigInt functions revaluated. Function removeByIndex revaluated. (#1256) * Add attachment field in order (#1140) * add attachment field in order * fix tests * Add more info to the error message. Refactor a bit 'TestAttachmentInOrder'. * add new feature and ride v8 for attachment in order * Correct features order ('TransactionStateSnapshot' == 22). * Bound exising logic to 'TransactionStateSnapshot' feature (version 1.5.0) according to the NODE-2531 task. * fix sign for order with attachment * fix issues and add tests * fix linters issues * create type for order's version * add test for order with rideV8 * Replace type alias with type for OrderVersion. * Type of the attachment in the Ride Order type updated to "ByteVector|Unit". * Old feature naming removed. Existing function Size of Attachement used to check the length of order's attachement. * Comments fixed. Obsolete TODO removed. --------- Co-authored-by: Nikolay Eskov <[email protected]> Co-authored-by: Alexey Kiselev <[email protected]> * Ride function replaceByIndex implemented and tested. (#1257) * Ride function replaceByIndex implemented and tested. * Arguments checks of list functions replaced by call to checkArgs function. Constant moved to function where it used. Functions max and min renamed to listMax and listMin because of the collision with built-in functions. * CalculateDelay Ride function implemented and partially tested. (#1259) * CalculateDelay Ride function implemented and partially tested. * Funciton calculateDelay updated according to new specification. Tests added. * Irrelevant comment removed. New function ID fixed. * Tests on correct scopes handling by estimator and evaluator added. (#1264) * Tests on correct scopes handling by estimator and evaluator added. Few compilation errors of FOLD fixed. Comparison of Any type to other types fixed in compilation. * Added test on FOLD compilation. Fixed SimpeType Equal function. * Deactivation of Ride versions 1, 2 and 3 on Light Node feature activation implemented. (#1278) Test added. --------- Co-authored-by: Anton Ilin <[email protected]> Co-authored-by: Nikolay Eskov <[email protected]> * Transaction version validation restored after activation on feature 22. (#1346) * Transaction version validation restored after activation on feature 22. * Fixed checkVersion parameter initialization. * Linter issues fixed for verifier.go. * Exchange transaction validation functions linter issues were fixed. * Simplified verification of Exchange transactions by interface type. * Stringer added to TransactionType for correct naming of transactions in API error messages. Simplified switch-case in verifier with private interface for transactions that supports Verify function. * Made Light Node feature disabled. It will be turned on in separate PR. * Error message improved. Comment fixed. --------- Co-authored-by: Nikolay Eskov <[email protected]> Co-authored-by: Anton Ilin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few compilation errors of FOLD fixed.
Comparison of Any type to other types fixed in compilation.