Feature: Generator for Plugs via Maven plugin #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cardil
force-pushed
the
feature/9-maven-generator
branch
2 times, most recently
from
e13a0be to
0db6b4d
Compare
cardil
force-pushed
the
feature/9-maven-generator
branch
from
0db6b4d to
00ecc93
Compare
A basic Packager logic has been added. Most of the code has been inspired by Spring Boot Maven plugin, but code has been strimlined to suit simplier needs of building just bundle jars. Packager logic should be rewriten so it will package sources, and add libraries and not to repackage original Jar as in Spring Boot solution. Basic manifest builder has been writen, but it needs more work to be suited for OSGi.
* Adding tests for Maven plugin * Adding complete test infrastructure for Maven plugin. * Plugin is able to work with DI maven container. Refers to issue #9
There are couple of further tasks: * Better decision of noop is needed, based on source hash. * Write source artifact compiled sources into jar * Create real imports, from provided scope * Define dependencies, imports, sources, name & version in OSGi bundle manifest
Rewiting plugin to repackage main jar artifact as a plug. The behiviour is similar to Spring Boot plugin, as source artifact can hold any number of user customisations like custom files and manifests. Reusing it make whole process dependant on artifact, which is a minor downside, but offers better coverage of all users needs. To be able to easily test and also to enable to write other plugins in future, like Gradle, I need to move code that is not directly linked to maven to separate package: core. * Maven backed SLF4J Logger * Maven backed coordinates * Almost all of configuration, except Project class impl * Maven libraries scaffold * All Maven backend factories should be completed * Switched to VAVR on Core nad Maven tools * Cross platform fixes
cardil
force-pushed
the
feature/9-maven-generator
branch
from
00ecc93 to
c8dc944
Compare
* Added a sampler library and use it to create samples * Introduce API nad DEVEL modules for plugs packager
cardil
force-pushed
the
feature/9-maven-generator
branch
from
c8dc944 to
4c93495
Compare
cardil
force-pushed
the
feature/9-maven-generator
branch
from
e6e7a7b to
d878e56
Compare
cardil
force-pushed
the
feature/9-maven-generator
branch
from
d878e56 to
20ddd78
Compare
cardil
force-pushed
the
feature/9-maven-generator
branch
from
7ec1594 to
66464ad
Compare
cardil
force-pushed
the
feature/9-maven-generator
branch
from
d1f3c9e to
ae456b3
Compare
And couple other classes to fix SonarQube issues
cardil
force-pushed
the
feature/9-maven-generator
branch
from
ae456b3 to
da213ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Generator for Plugs via Maven plugin
Couple of extra tasks should be resolved before #9 can be completed: